git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug(let): status reports 'can fast-forward' when not true

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 21, 2009, 23:28 UTC
Message-ID
<7veivl60yt.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20090421210233.GB13151@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 29 quoted lines
> [cc'ing Kjetil, as this is a fallout of 19de5d6]
>
> On Tue, Apr 21, 2009 at 09:53:52PM +0100, Charles Bailey wrote:
>
>> I was not really thinking when I get fetched, and ran git status on my
>> pu branch. I was told that pu was behind origin/pu by 104 commits and
>> could be fast-forwarded, so I git merged origin/pu and was mildly
>> surprised when git merge made a commit for me.
>> 
>> A quick investigation revealed that pu had (of course) been rewound,
>> but the only commits that it had that the new pu didn't, were merge
>> commits.
>
> I think this is an unintended consequence of 19de5d6
> (stat_tracking_info(): only count real commits, 2009-03-04). It is
> perhaps more useful when seeing the actual numbers to see only the count
> of real commits, but it makes statements like "can be fast-forwarded" no
> longer true.
>
> So I think we need to either:
>
>   1. reword the "can be fast-forwarded" text to something else
>
>   2. revert 19de5d6, since merge commits _can_ be interesting
>
>   3. refactor stat_tracking_info to return "real" and "merge" counts,
>      and change the text for the case of "real == 0 && merge > 0".
>
> -Peff
Let's revert it for now and then try #3 after 1.6.3 final.
Previous: Jeff KingNext: Kjetil Barvik
Message 3 of 4 in “Bug(let): status reports 'can fast-forward' when not true”
  1. Charles BaileyApr 21, 2009
  2. Jeff KingApr 21, 2009
  3. Junio C HamanoApr 21, 2009
  4. Kjetil BarvikApr 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.