Re: [PATCH] Fix minor memory leak in init-db
Ammon Riley <ammon.riley@gmail.com> writes:
Show 15 quoted lines
> On Sat, May 16, 2009 at 12:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ammon Riley <ammon.riley@gmail.com> writes:
>>
>>> There was an xmalloc() for path, but I didn't see a corresponding free().
>>> Does it happen somewhere else that I'm not expecting?
>>
>> It implicitly happens in exit() in git.c:handle_internal_command()
>> after cmd_init_db() returns the control to it.
>
> Ah. Naturally. :)
>
> So if I were to write a long-lived application (such as a custom UI) that
> links to libgit, and bypasses those functions to call init_db() (and other
> functions) directly, all those implicit free-on-exit() turn into memory
> leaks.
Correct, and there are other much larger issues to worry about.
That's why there is a separate libgit2 effort in progress.
Junio C Hamano <gitster@pobox.com>