git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] symlinks.c: small style cleanup

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 7, 2009, 16:30 UTC
Message-ID
<7veitwatvy.fsf@alter.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0906071616060.26154@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> On Sun, 7 Jun 2009, Kjetil Barvik wrote:
>
>> Add {}-braces around an else-part, where the if-part already has
>> {}-braces.
>
> This is the wrong way round.  We prefer _not_ to add unnecessary braces, 
> but do tolerate them from time to time.

I am at fault not spelling this out so far, but we prefer to match the kernel style of having {} around a single-statment "else" body when the corresponding "if" side needs one (or vice versa).

Previous: Johannes SchindelinNext: Kjetil Barvik
Message 3 of 4 in “symlinks.c: small style cleanup”
  1. symlinks.c: small style cleanupKjetil Barvik, Jun 7, 2009
  2. Johannes SchindelinJun 7, 2009
  3. Junio C HamanoJun 7, 2009
  4. Kjetil BarvikJun 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.