git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Add support for the google-chrome web browser

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 5, 2010, 19:56 UTC
Message-ID
<7veim4xr47.fsf@alter.siamese.dyndns.org>
In-Reply-To
<32541b131001051056o5853b1d2xd57d75d9a62f9f1a@mail.gmail.com>
Avery Pennarun <apenwarr@gmail.com> writes:
Show 5 quoted lines
> The current behaviour will barf right away (I think) because it
> doesn't know.  If it instead had a default case that just assumed
> non-firefox behaviour, then it would fail *strangely* (instead of
> predictably) on browsers that needed special workarounds, such as an
> as-yet-unknown firefox derivative.
Ok, I can buy that.

I have a feeling that extensibility situation of this script is similar to that of mergetool/difftool. Perhaps a similar approach to refactor and then support browser-specific peculiarities by separate files, outlined in http://thread.gmane.org/gmane.comp.version-control.git/134906/focus=135006 might work well, don't you think?

Previous: Avery Pennarun
Message 6 of 6 in “Add support for the google-chrome web browser”
  1. Add support for the google-chrome web browserEvan Farrer, Jan 5, 2010
  2. Junio C HamanoJan 5, 2010
  3. Avery PennarunJan 5, 2010
  4. Junio C HamanoJan 5, 2010
  5. Avery PennarunJan 5, 2010
  6. Junio C HamanoJan 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.