Re: wishlist: git send-email improvement

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 9, 2010, 17:30 UTC
Message-ID: <7veijtz9kn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1268155306.4277.14.camel@localhost>

Yann Droneaud <yann@droneaud.fr> writes:

Show 6 quoted lines

> Here's a little wishlist for send-email
>
> - Use From: field extracted from patch:
>   If there's no configuration for user.email and From: field is 
>   different than default auto generated From: address, 
>   git send-email should use the one in the patch as default.

I cannot judge how sensible this change is; please justify the motivation by adding "it currently does _this_, which is not good for _such and such reasons_; instead" between the third and the fourth line.

Show 6 quoted lines

> - Use To: field extracted from patch
>   I've setup format-patch to add a default To: field with
>   format.headers="To: xxx@yyy". But git send-email did not use it and 
>   ask for a To: value.
>   If there's no --to or sendmail.to, send-email should use To: value 
>   extracted from patch and ask for user confirmation.

With the recent addition of format.to that is cooking somewhere, I think this one is probably sensible.