Re: Make author and committer available to pre-commit hook

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2010, 15:47 UTC
Message-ID: <7veifg4nom.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTilsdbJLHTY7cx2GeZg9ai_OZhmnEt0KdFjF81Pd@mail.gmail.com>

Gisle Aas <gisle@aas.no> writes:

> One question that arise is what format the date variables should have.
> Is the raw format (that is "1278400946 +0200") sensible?

I'd say so. We are doing this for scripts (hooks) and there is not much point doing machine-readable-to-human conversion they could do if they so choose.

> I've created a patch for this locally, but it has some side effects in
> messing up the dates stored by 'git commit -C...' which I have not
> figured out yet; and now I need to get some other stuff done.

I imagine that you would be sending the date information just the same way you send the author information, so if your addition messes up the dates for "commit -C", wouldn't your original patch mess up the authorship information the same way?

In any case, this new feature won't be in 'master' nor 'next' while we are in pre-release freeze, so no need to rush.

Thanks.