Re: [PATCH 1/2] add support for the SUA layer (interix; windows)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2010, 00:50 UTC
Message-ID: <7veib99608.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1288168793-11159-2-git-send-email-markus.duft@salomon.at>

mduft@s01en22.salomon.at writes:

Show 17 quoted lines

> diff --git a/daemon.c b/daemon.c
> index 9326d3a..d68a31f 100644
> --- a/daemon.c
> +++ b/daemon.c
> @@ -956,7 +956,11 @@ static int serve(char *listen_addr, int listen_port, struct passwd *pass, gid_t
>  		    listen_addr, listen_port);
>  
>  	if (pass && gid &&
> -	    (initgroups(pass->pw_name, gid) || setgid (gid) ||
> +	    (
> +#ifndef NO_INITGROUPS
> +		    initgroups(pass->pw_name, gid) || 
> +#endif
> +	     setgid (gid) ||
>  	     setuid(pass->pw_uid)))
>  		die("cannot drop privileges");
>

It would be much nicer to do this:

        #ifdef NO_INITGROUPS
        #define initgroups(x,y) (0) /* nothing */
        #endif

near the beginning of the file. That would make life of people who have changes in flight that would touch the same area of the code a lot easier.