git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] wt-status.c: Increase code readability.

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 26, 2011, 17:13 UTC
Message-ID
<7vei4pey1b.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1303817198-23347-1-git-send-email-henrik@fiktivkod.org>
Henrik Hautakoski <henrik@fiktivkod.org> writes:
> Some if/else statements has braces on only some branches. Be consistent and make
> all branches have braces.
>
> Signed-off-by: Henrik Hautakoski <henrik@fiktivkod.org>

While I agree that this patch makes things consistent, and consistency may be good, but "readable" is more subjective.

Perhaps retitle it to "Subject: wt-status.c: style fixes"? That would be more consistent (no pun intended) with the body of the message.

Please hold onto this patch, and make it the first one in the series of whatever you are planning to do to wt-status.c that you mentioned.

Previous: Henrik Hautakoski
Message 2 of 2 in “wt-status.c: Increase code readability.”
  1. wt-status.c: Increase code readability.Henrik Hautakoski, Apr 26, 2011
  2. Junio C HamanoApr 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.