Re: Doesn't disambiguate between 'external command failed' and 'command not found'

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2011, 23:25 UTC
Message-ID: <7vei23htzz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110706180026.GC17978@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Wed, Jul 06, 2011 at 01:58:03PM -0400, Jeff King wrote:
>
>> > Like this? I've replaced "Check the #!-line of the git-%s script." with
>> > "Maybe git-%s is broken?" to be less technical and specific..
>> 
>> Yeah, looks good to me (unless somebody wants to do something more
>> elaborate to catch other exec problems, but I personally don't think
>> it's worth the effort).
>
> One minor nit, though. I haven't been paying attention to the progress
> of the gettext topics, but should this message:
>
>> +static const char bad_interpreter_advice[] =
>> +	"'%s' appears to be a git command, but we were not\n"
>> +	"able to execute it. Maybe git-%s is broken?";
>
> Actually be inside _() for gettext?

I would mark it with N_() and then the calling site inside die() with _() if I were doing this.