git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails.

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2011, 07:45 UTC
Message-ID
<7vei1gw28w.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1311469670-15392-3-git-send-email-jon.seymour@gmail.com>
Jon Seymour <jon.seymour@gmail.com> writes:
Show 35 quoted lines
> In the case of a corrupt repository, git ls-tree may report an error but
> presently it exits with a code of 0.
>
> This change uses the return code of read_tree_recursive instead.
>
> Improved-by: Jens Lehmann <Jens.Lehmann@web.de>
> Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
> ---
>  builtin/ls-tree.c               |    6 +++---
>  t/t3103-ls-tree-missing-tree.sh |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
> index f08c5b0..6d6c992 100644
> --- a/builtin/ls-tree.c
> +++ b/builtin/ls-tree.c
> @@ -120,7 +120,7 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
>  {
>  	unsigned char sha1[20];
>  	struct tree *tree;
> -	int i, full_tree = 0;
> +	int i, full_tree = 0, err;
>  	const struct option ls_tree_options[] = {
>  		OPT_BIT('d', NULL, &ls_options, "only show trees",
>  			LS_TREE_ONLY),
> @@ -173,7 +173,7 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
>  	tree = parse_tree_indirect(sha1);
>  	if (!tree)
>  		die("not a tree object");
> -	read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
> +	err = read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
>  
> -	return 0;
> +	return err;
>  }
Makes sense.  Thanks.
Previous: Jon SeymourNext: Jens Lehmann
Message 6 of 7 in “ls-tree: exit with non-zero status on error”
  1. 0/2 ls-tree: exit with non-zero status on errorJon Seymour, Jul 24, 2011
  2. 1/2 Add a test to check that git ls-tree sets non-zero exit code on error.Jon Seymour, Jul 24, 2011
  3. Junio C HamanoJul 24, 2011
  4. Jon SeymourJul 24, 2011
  5. 2/2 Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails.Jon Seymour, Jul 24, 2011
  6. Junio C HamanoJul 24, 2011
  7. Jens LehmannJul 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.