git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git patch-id fails on long lines

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2011, 20:11 UTC
Message-ID
<7vehzb5602.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1316541771-sup-9996@pimlott.net>
Andrew Pimlott <andrew@pimlott.net> writes:
> In patch-id.c, get_one_patchid uses a fixed 1000-char buffer to read a line.

Thanks; builtin/patch-id.c is parhaps one of the more ancient part of the system and it hasn't been updated to use more modern facility like strbuf API.

Fix should be pretty straightforward. Any takers?
Previous: Andrew PimlottNext: Michael Schubert
Message 2 of 5 in “git patch-id fails on long lines”
  1. Andrew PimlottSep 20, 2011
  2. Junio C HamanoSep 20, 2011
  3. patch-id.c: use strbuf instead of a fixed bufferMichael Schubert, Sep 21, 2011
  4. Jeff KingSep 22, 2011
  5. Jeff KingSep 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.