Re: [PATCH] inet_ntop.c: Work around GCC 4.6's detection of uninitialized variables
Sebastian Schuberth <sschuberth@gmail.com> writes:
Show 23 quoted lines
> GCC 4.6 claims that
>
> error: 'best.len' may be used uninitialized in this function
>
> so silence that warning which is treated as an error by also initializing
> the "len" members of the struct.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
> compat/inet_ntop.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/compat/inet_ntop.c b/compat/inet_ntop.c
> index ea249c6..60b5a1d 100644
> --- a/compat/inet_ntop.c
> +++ b/compat/inet_ntop.c
> @@ -98,7 +98,9 @@ inet_ntop6(const u_char *src, char *dst, size_t size)
> for (i = 0; i < NS_IN6ADDRSZ; i++)
> words[i / 2] |= (src[i] << ((1 - (i % 2)) << 3));
> best.base = -1;
> + best.len = 0;
> cur.base = -1;
> + cur.len = 0;
It may be just the "taste" thing, but I wonder if
best.base = -1;
best.len = 0;
cur = best;might be easier on the eyes.
Will queue as-is anyway. Thanks.
> for (i = 0; i < (NS_IN6ADDRSZ / NS_INT16SZ); i++) {
> if (words[i] == 0) {
> if (cur.base == -1)Junio C Hamano <gitster@pobox.com>