Re: sha-1 check in rev-list --verify-objects redundant?

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2012, 18:41 UTC
Message-ID: <7vehtg9l0a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120227130141.GA8980@do>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

Show 15 quoted lines

> On Sun, Feb 26, 2012 at 06:11:30PM +0700, Nguyen Thai Ngoc Duy wrote:
>> "rev-list --objects" does check for blob existence, in finish_object().
>
> Eck.. I think "--quiet --verify-objects" becomes "--quiet --objects"
> because of this code:
>
> -- 8< --
> 	traverse_commit_list(&revs,
> 			     quiet ? finish_commit : show_commit,
> 			     quiet ? finish_object : show_object,
> 			     &info);
> -- 8< --
>
> Unless that's intentional, shouldn't we apply this patch? --quiet's
> interfering with rev-list's business sounds weird to me.

Good thinking. Anything we are missing by calling finish_* other than printing is a similar bug waiting to happen.

Can't we push the quiet bit in the info structure and have a single pair of callback functions, so that we can make sure this kind of glitch would never happen?