git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] submodule add + autocrlf + safecrlf

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 20, 2012, 19:24 UTC
Message-ID
<7vehp9vlbf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4FE211C8.3080007@kitware.com>
Brad King <brad.king@kitware.com> writes:
Show 12 quoted lines
> On 06/20/2012 01:49 PM, Junio C Hamano wrote:
>> I have a suspicion that "git config" should be taught about this
>> kind of thing instead.
>> 
>> Shoudn't your .git/config file that is outside the revision control
>> also end with CRLF if your platform and project prefer CRLF over LF?
>
> That would be reasonable, but is beyond the scope I'm willing to
> tackle myself.
>
> I don't actually have a project like this so I have no strong
> opinion on this issue.

If that is the case, my preference would be to wait until that "git config" change happens (provided that it is a reasonably way forward---it may turn out to be a bad idea) and do nothing to clutter "git submodule" at all. In the meantime, if there are real projects that are hurt by this, we can tell them to explicitly specify that .gitmodules is a LF text file in their .gitattributes.

Previous: Brad King
Message 12 of 12 in “submodule add + autocrlf + safecrlf”
  1. 0/2 submodule add + autocrlf + safecrlfBrad King, Jun 20, 2012
  2. 1/2 submodule: Demonstrate failure to add with auto/safecrlfBrad King, Jun 20, 2012
  3. 2/2 submodule: Tolerate auto/safecrlf when adding .gitmodulesBrad King, Jun 20, 2012
  4. Jens LehmannJun 20, 2012
  5. Brad KingJun 20, 2012
  6. Jens LehmannJun 20, 2012
  7. Jeff KingJun 20, 2012
  8. Junio C HamanoJun 20, 2012
  9. Jens LehmannJun 21, 2012
  10. Junio C HamanoJun 20, 2012
  11. Brad KingJun 20, 2012
  12. Junio C HamanoJun 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.