Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 13, 2012, 20:29 UTC
- Message-ID
- <7vehof8kx5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <500078E4.3000901@xiplink.com>
Marc Branchaud <marcnarc@xiplink.com> writes:
Show 11 quoted lines
>> Is it even a _side effect_? Isn't this one of the primary points of >> the series? I do not think this patch makes sense if we did not >> want that change to happen. >> >> Or am I missing something? > > No, you're not -- I agree that this change in behaviour makes sense. I > simply hadn't anticipated this effect when I first did the work. > > So should the commit message simply say "This changes the default behavior of > 'git push' ..."? Or are you suggesting the message needn't mention it at all?
It is one of the more important behaviour changes we are making on purpose with this series; it deserves to be described in the log, I would think.