Re: push.default documented in "man git-push"?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2012, 16:17 UTC
- Message-ID
- <7vehl57zkh.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <vpqhaq13xdq.fsf@grenoble-inp.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 13 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes: > >> On Fri, Oct 05, 2012 at 01:03:28PM -0700, Junio C Hamano wrote: >> >>> OK, the messages are supposed to advise how to turn them off, so we >>> would want some code updates in that case. >> >> Something like this? It turns out none of the advice messages says >> anything about advice.*. > > Personally, I'm fine with the current situation. Advanced users can read > the documentation, and for others, the messages are usually more helpful > than annoying.
OK, you convinced me.
Show 14 quoted lines
> I disagree. Having advices turned on doesn't harm anyone. I don't > remember anyone complaining about the verbosity of Git's advices. I've > seen *many* more people complaining about the user-unfriendliness of > Git. > > I'm fine with very verbose (and scary) messages when the user did > something wrong (for example, the advice.implicitIdentity is something > you should never see if you configured Git properly before commiting). > But the user should not feel blamed for using the default configuration > of advice messages. The tripple repetition in "git status" shown above > really sounds like "hey, dumb user, why did you not set > advice.statusHints already", and is doubly scary for newbies, because > they are not told how to set the variable, nor what a config variable is > to Git.
Let's let the list of advice.* messages in Documentation/config.txt do their job.
Nguyen, thanks for taking a look. I do agree the extra "here is how to rob helpful hints from yourself before you learn them" seems to do more harm than good.