Re: Build broken for contrib/remote-helpers...

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 22, 2013, 22:22 UTC
Message-ID: <7vehhcn9i9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50FEFCD7.2060402@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 6 quoted lines

>> So it finds whatever is before the first "-", which would be the test
>> number in "t0000-basic.sh" or similar, and then looks for duplicates.
>
> would it help to filter for numbered tests before sorting like this:
>
> sed 's/-.*//' | grep "[0-9][0-9][0-9][0-9]"| sort | uniq -d

If you are using sed you do not need grep. Just do that in a single process, perhaps like

	sed -ne 's|\(.*/\)*t\([0-9][0-9][0-9][0-9]\)-.*|\2|p'

But more importantly, what do we want "duplicate numbers" sanity check to mean in this context? Is this other directory allowed to have a numbered test that shares the same number as the main test suite? Is uniqueness inside the contrib/remote-helpers/ directory sufficient?

Do we envision that perhaps someday the contrib material becomes mature enough and will want to migrate to the main part of the tree? If that is the case, perhaps should the check complain that these tests are not numbered, instead of ignoring?