Re: [PATCH] Makefile: don't run rm without any files

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2013, 20:01 UTC
Message-ID: <7vehgk6l11.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130213170028.GA410@ftbfs.org>

Matt Kraai <kraai@ftbfs.org> writes:

Show 12 quoted lines

> I don't set COMPUTE_HEADER_DEPENDENCIES, so it defaults to "auto".
> The automatic detection determines that the compiler doesn't support
> it, so it's then set to "no".  CHECK_HEADER_DEPENDENCIES isn't set
> either, so about 20 lines below the dep_dirs assignment you quoted,
> dep_dirs is cleared:
>
>  ifneq ($(COMPUTE_HEADER_DEPENDENCIES),yes)
>  ifndef CHECK_HEADER_DEPENDENCIES
>  dep_dirs =
>  ...
>
> Should I submit an updated patch with a different commit message?

I amended the log message like so:

commit bd9df384b16077337fffe9836c9255976b0e7b91
Author: Matt Kraai <matt.kraai@amo.abbott.com>
Date:   Wed Feb 13 07:57:48 2013 -0800

    Makefile: don't run rm without any files
    
    When COMPUTE_HEADER_DEPENDENCIES is set to "auto" and the compiler
    does not support it, $(dep_dirs) becomes empty.  "make clean" runs
    "rm -rf $(dep_dirs)", which fails in such a case.
    
    Signed-off-by: Matt Kraai <matt.kraai@amo.abbott.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>