Re: [PATCHv2 7/7] git grep: honor textconv by default
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 24, 2013, 17:35 UTC
- Message-ID
- <7vehdzesr9.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <5177AE7F.1040400@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
> My point is that we apply textconv on "log diff greps" already, so why > should't we on content greps?
I think you are going in circles. If you start from "textconv is about mangling blob contents", then it would look natural to you that "show <blob>", "diff A B", and "grep <pattern> <blob>" would all first mangle the blob contents using textconv and then work on them.
But diff.<driver>.textconv is to mangle blob contents in preparation for comparing with another.
That is why you explicitly ask "cat-file --textconv" to use the same mangling even when you are not comparing it with anything else.