Re: [PATCH v2] clone: allow cloning local paths with colons in them

From: Junio C Hamano <gitster@pobox.com>
Date: May 7, 2013, 15:34 UTC
Message-ID: <7vehdils6c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1367633973-26214-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 12 quoted lines

> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 67869b4..0629149 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -280,4 +280,9 @@ test_expect_success 'clone checking out a tag' '
>  	test_cmp fetch.expected fetch.actual
>  '
>  
> +test_expect_success NOT_MINGW,NOT_CYGWIN 'clone local path foo:bar' '
> +	cp -R src "foo:bar" &&
> +	git clone "./foo:bar" foobar
> +'

Hmph, why not

	git clone --mirror src foo:bar &&
        git clone ./foo:bar foobar

or something? Also do we have a easy negative case we want to test, i.e. a case where we do not want the new codepath to trigger by mistake?