git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: Fix a memory leak in determine_author_info

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 15, 2013, 14:42 UTC
Message-ID
<7vehazevf3.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1373810463-7144-1-git-send-email-stefanbeller@googlemail.com>
Stefan Beller <stefanbeller@googlemail.com> writes:
Show 19 quoted lines
> The date variable is assigned new memory via xmemdupz and 2 lines later
> it is assigned new memory again via xmalloc, but the first assignment
> is never freed nor used.
> ---
>  builtin/commit.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 790e5ab..00da83c 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf *author_ident)
>  					(lb - strlen(" ") -
>  					 (a + strlen("\nauthor "))));
>  		email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
> -		date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
>  		len = eol - (rb + strlen("> "));
>  		date = xmalloc(len + 2);
>  		*date = '@';
Makes sense. I'd assume this is signed-off?
Previous: Stefan BellerNext: Stefan Beller
Message 2 of 3 in “commit: Fix a memory leak in determine_author_info”
  1. commit: Fix a memory leak in determine_author_infoStefan Beller, Jul 14, 2013
  2. Junio C HamanoJul 15, 2013
  3. Stefan BellerJul 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.