Re: [PATCH] Fix errno usage in connect.c

From: Junio C Hamano <junkio@cox.net>
Date: Jul 2, 2006, 00:09 UTC
Message-ID: <7vd5codfzn.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060701215626.GB29115@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

Show 14 quoted lines

> Dear diary, on Wed, Jun 28, 2006 at 06:56:12PM CEST, I got a letter
> where Morten Welinder <mwelinder@gmail.com> said that...
>> It looks like connect.c waits too long before it uses errno in both copies
>> of git_tcp_connect_sock.  Both close and freeaddrinfo can poke any
>> non-zero value in there.
>
> Nice catch.
>
> ->8-
>
> errno was used after it could've been modified by a subsequent library call.
> Spotted by Morten Welinder.
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>

Thanks.