Re: [PATCH] Make git-commit cleverer - have it figure out whether it needs -a automatically

From: Junio C Hamano <junkio@cox.net>
Date: Dec 1, 2006, 11:15 UTC
Message-ID: <7vd573amuy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612011106.42272.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 14 quoted lines

> Raimund Bauer offered this suggestion (paraphrased):
>
> "Maybe we could do git-commit -a  _only_ if the index matches HEAD, and
> otherwise keep current behavior?  So people who don't care about the
> index won't get tripped up, and when you do have a dirty index, you get
> told about it?"
>
> Johannes Schindelin pointed out that this isn't the right thing to do for
> an --amend, so that is checked for. Additionally, it's probably not the
> right thing to do if any files are specified with "--only" or
> "--include", so they turn this behaviour off as well.
>
> Nguyen Thai Ngoc Duy asked that git-commit let you know it's done this
> by adding an extra comment to the commit message.

I think another exception should be needed. If the index does not match the working tree, it should not default to "-a".

Otherwise,

I want to fix another thing in pickaxe.

	$ edit builtin-blame.c

My wife calls me. Away from desk for 20 minutes. Later I come back.

	$ git update-index builtin-pickaxe.c

I am so used to that name and did not realize that typo, and I was not paying too much attention. My wife calls me again. Away from desk and back in 20 minutes.

	$ git commit -m 'git-blame: Another fix.'

Oops.

So, please turn this "cleverness" off when the index does not match the working tree.