Re: [PATCHv3] git-fetch: Split fetch and merge logic

From: Junio C Hamano <junkio@cox.net>
Date: Feb 24, 2007, 09:30 UTC
Message-ID: <7vd53zzyvo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8aa486160702230242r4059811ewbc4cb5c6d33500df@mail.gmail.com>

"Santi Béjar" <sbejar@gmail.com> writes:

Show 8 quoted lines

> On 2/23/07, Junio C Hamano <junkio@cox.net> wrote:
>
>> I am wondering if FETCH_FETCHED is purely for internal use by
>> git-fetch (it appears so), and if so if it is worth trying to do
>> without the temporary file, but that is a minor detail.
>
> Yes, it's purely internal. With "without the temporary file" you mean
> to put the content in a variable or removing at the end?

If a variable suffices that would be quite nice, but it is not a big deal. As the script does fair amount of computation in subprocess, I suspect it may not be worth trying to use variable, only to get rid of the temporary file.

Show 8 quoted lines

>> I appreciate the cleverness of the intersection.  However, is
>> "echo -e" portable?  I think we have avoided it so far (we have
>> avoided even "echo -n" which is traditionally much more
>> available).
>
> printf '%s\n%s' "$merge_branches" "$fetch_branches"
>
> is OK?

Yes. I think printf is what people who rewrote my "echo -n" have done elsewhere.