git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/resend] add--interactive: allow diff colors without interactive colors

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 5, 2008, 11:11 UTC
Message-ID
<7vd4sga5n6.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1199530684.6209.6.camel@futex>
Matthias Kestenholz <mk@spinlock.ch> writes:
> I managed to throw something together which works and passes all
> the tests. Documentation included. :-)

Is it because we do not usually test colours and the tests run without terminals to make sure "color.* = auto" does not kick in?

> I would be happy for feedback and suggestions.
 * Shouldn't "color.git = true" with "color.diff = false" mean
   "I want colour for everything by default but I do not want to
   see coloured diff"?
 * git_foo_config() callback from git_config() returns 0 on
   success; the API change needs to be documented to warn
   others.

I haven't studied your patch very deeply so I may have misread what you tried to do, regarding the first point, though.

Previous: Matthias KestenholzNext: Matthias Kestenholz
Message 9 of 17 in “add--interactive: allow diff colors without interactive colors”
  1. add--interactive: allow diff colors without interactive colorsJeff King, Jan 4, 2008
  2. Junio C HamanoJan 5, 2008
  3. Jeff KingJan 5, 2008
  4. Junio C HamanoJan 5, 2008
  5. Jeff KingJan 5, 2008
  6. Junio C HamanoJan 5, 2008
  7. Jeff KingJan 5, 2008
  8. Matthias KestenholzJan 5, 2008
  9. Junio C HamanoJan 5, 2008
  10. Matthias KestenholzJan 5, 2008
  11. 1/4 Add infrastructure for a single color config variableMatthias Kestenholz, Jan 5, 2008
  12. 2/4 git branch: Use color configuration infrastructureMatthias Kestenholz, Jan 5, 2008
  13. 3/4 status and commit: Use color configuration infrastructureMatthias Kestenholz, Jan 5, 2008
  14. 4/4 diff and log: Use color configuration infrastructureMatthias Kestenholz, Jan 5, 2008
  15. Jeff KingJan 8, 2008
  16. Matthias KestenholzJan 8, 2008
  17. Jakub NarebskiJan 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.