Re: [PATCH] HP-UX traditionally has no sys/select.h
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 24, 2008, 19:11 UTC
- Message-ID
- <7vd4rravin.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080124175300.GI30676@schiele.dyndns.org>
Robert Schiele <rschiele@gmail.com> writes:
Show 23 quoted lines
> The select stuff is already in sys/time.h on traditional HP-UX > systems thus we should not include sys/select.h there because older > releases don't have it. > --- > git-compat-util.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/git-compat-util.h b/git-compat-util.h > index b6ef544..77de915 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -68,7 +68,9 @@ > #include <sys/poll.h> > #include <sys/socket.h> > #include <sys/ioctl.h> > +#ifndef __hpux > #include <sys/select.h> > +#endif > #include <assert.h> > #include <regex.h> > #include <netinet/in.h> > -- > 1.5.2.4
We had a thread on this issue mid December. Does this help?
>From 72a41cae180ad57c6f2daa0af9b96e284386dc1b Mon Sep 17 00:00:00 2001
From: Junio C Hamano <gitster@pobox.com> Date: Tue, 18 Dec 2007 01:52:07 -0800 Subject: [PATCH] Do not include <sys/select.h> on pre- POSIX.1-2001 systems
For previous version of SUS, select(2) would have been declared in <sys/time.h>, which is already included. POSIX.1-2001 moved the declaration to <sys/select.h>, so check _POSIX_VERSION with 200112L and skip inclusion of <sys/select.h> if it is not the case.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- git-compat-util.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h index b6ef544..fb3b969 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -68,7 +68,9 @@ #include <sys/poll.h> #include <sys/socket.h> #include <sys/ioctl.h> +#if _POSIX_VERSION >= 200112L #include <sys/select.h> +#endif #include <assert.h> #include <regex.h> #include <netinet/in.h>
-- 1.5.4.rc4.23.gcab31