Re: [PATCH] git-submodule - Fix errors regarding resolve_relative_url

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2008, 18:28 UTC
Message-ID: <7vd4mjhnwk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1213463381-3316-1-git-send-email-mlevedahl@gmail.com>

Mark Levedahl <mlevedahl@gmail.com> writes:

> git-submodule was invoking "die" from within resolve-relative-url, but
> this does not actually cause the script to exit. Fix this by returning
> the error to the caller and have the caller exit.

Thanks for catching this. But don't you think the first hunk is unnecessary?

> While we're at it, clean up the quoting on invocation of
> resolve_relative_url as it was wrong.

Yup. if you make it pass through the non-zero exit status that would be perfect, like this:

    realrepo=$(resolve_relative_url "$repo") || exit