git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Teach fsck and prune about the new location of temporary objects

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 25, 2008, 06:07 UTC
Message-ID
<7vd4l2xzrd.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0807250233031.4140@eeepc-johanness>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> On Thu, 24 Jul 2008, Brandon Casey wrote:
>
>> Since 5723fe7e, temporary objects are now created in their final destination
>> directories, rather than in .git/objects/. Teach fsck to recognize and
>> ignore the temporary objects it encounters,
>
> It somehow feels wrong for fsck to ignore anything that could be used.

Back when we created temporaries in .git/objects/, these tmp_obj files were not even checked nor looked at, because fsck_object_dir() checked only those 256 fan-out directories, so this is nothing new.

And these tmp_obj files are something we _expect_ to be in the object directory. The user can ^C out object creation codepath anytime, and we do not reference the final destination objects from refs nor the index to preserve the integrity of the repository when that happens. In other words, they are crufts, but they are not something unusual nor get alarmed about.

And it also is the right thing to do to remove them in prune.
Previous: Johannes SchindelinNext: Shawn O. Pearce
Message 3 of 5 in “Teach fsck and prune about the new location of temporary objects”
  1. Teach fsck and prune about the new location of temporary objectsBrandon Casey, Jul 24, 2008
  2. Johannes SchindelinJul 25, 2008
  3. Junio C HamanoJul 25, 2008
  4. fsck: Don't require tmp_obj_ file names are 14 bytes in lengthShawn O. Pearce, Jul 27, 2008
  5. Junio C HamanoJul 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.