Re: GIT-VERSION-GEN gives "-dirty" when file metadata changed

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2008, 21:48 UTC
Message-ID: <7vd4kkijjd.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <sjj6zt28jy9qy7y8@jaeger.mine.nu>

Christian Jaeger <christian@jaeger.mine.nu> writes:

> Today I've created custom Debian packages from Git for the first time (yes I know there are Debian packages already, I'm doing it so that I can patch Git and still have the convenience of a package system),

I personally think that _you_ are responsible for doing the refresh yourself after becoming root, if you checkout as yourself and then build as root (or use fakeroot to build as if it is built as root).

By the way "man fakeroot" says...

       -u, --unknown-is-real
              Use the real ownership of files previously unknown  to  fakeroot
              instead of pretending they are owned by root:root.

which sounds like a sensible thing to do (I would even imagine that would be a sensible default for fakeroot in general), and I would imagine that would help.

Not that an extra update-index --refresh would be a huge performance hit, but I hesitate to take a patch that adds something that should conceptually be unnecessary.