Re: [PATCH] http-push.c: DAV must support olny http and https scheme
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 12, 2009, 08:48 UTC
- Message-ID
- <7vd4bi9s1m.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1239371060-3978-1-git-send-email-catap@catap.ru>
"Kirill A. Korinskiy" <catap@catap.ru> writes:
Show 33 quoted lines
> If the response from remote web-server have scp or other not http-like
> scheme http-push can't go to change url, because DAV must work only
> over HTTP (http and https scheme).
>
> Signed-off-by: Kirill A. Korinskiy <catap@catap.ru>
> ---
> http-push.c | 19 ++++++++++---------
> 1 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/http-push.c b/http-push.c
> index feeb340..48c9a04 100644
> --- a/http-push.c
> +++ b/http-push.c
> @@ -1457,16 +1457,17 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
> }
> } else if (!strcmp(ctx->name, DAV_PROPFIND_NAME) && ctx->cdata) {
> char *path = ctx->cdata;
> - if (*ctx->cdata == 'h') {
> - path = strstr(path, "//");
> - if (path) {
> - path = strchr(path+2, '/');
> - }
> - }
> - if (path) {
> - path += repo->path_len;
> - ls->dentry_name = xstrdup(path);
> + if (!strcmp(ctx->cdata, "http://")) {
> + path = strchr(path + sizeof("http://") - 1, '/');
> + } else if (!strcmp(ctx->cdata, "https://")) {
> + path = strchr(path + sizeof("https://") - 1, '/');
> }
> +
> + path += remote->path_len;http-push.c: In function 'handle_remote_ls_ctx': http-push.c:1466: error: 'remote' undeclared (first use in this function) http-push.c:1466: error: (Each undeclared identifier is reported only once http-push.c:1466: error: for each function it appears in.)
Ah, crap.
Show 8 quoted lines
> + ls->dentry_name = xmalloc(strlen(path) -
> + remote->path_len + 1);
> + strcpy(ls->dentry_name, path + remote->path_len);
> } else if (!strcmp(ctx->name, DAV_PROPFIND_COLLECTION)) {
> ls->dentry_flags |= IS_DIR;
> }
> --
> 1.6.2