git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] show-branch: don't use LASTARG_DEFAULT with OPTARG

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2009, 21:56 UTC
Message-ID
<7vd49ewfsi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1244417955-21226-1-git-send-email-bebarino@gmail.com>
Stephen Boyd <bebarino@gmail.com> writes:
Show 5 quoted lines
> 5734365 (show-branch: migrate to parse-options API 2009-05-21)
> incorrectly set the --more option's flags to be
> PARSE_OPT_LASTARG_DEFAULT and PARSE_OPT_OPTARG. These two flags
> shouldn't be used together. An option taking a default should just set
> the default value desired and parse options will take care of the rest.

Thanks. Perhaps as a follow-up patch the runtime can check and barf when parse_options() is called and finds this combination?

Previous: René ScharfeNext: Pierre Habouzit
Message 6 of 9 in “parse-options: ambiguous LASTARG_DEFAULT and OPTARG”
  1. Stephen BoydJun 5, 2009
  2. René ScharfeJun 6, 2009
  3. Stephen BoydJun 6, 2009
  4. show-branch: don't use LASTARG_DEFAULT with OPTARGStephen Boyd, Jun 7, 2009
  5. René ScharfeJun 8, 2009
  6. Junio C HamanoJun 8, 2009
  7. parse-options: add parse_options_check to validate option specs.Pierre Habouzit, Jun 9, 2009
  8. Pierre HabouzitJun 12, 2009
  9. René ScharfeJun 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.