git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/4] Add explicit Cygwin check to guard WIN32 header inclusion

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 9, 2009, 22:25 UTC
Message-ID
<7vd43rpc8q.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4AF86E0C.4080001@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 6 quoted lines
> Changes since v2:
>     - removed indentation from the #if-#endif block
>
> I hope you don't mind, but I've only sent this patch, rather than
> re-send the whole series. If you would like a complete re-send, just
> let me know.

No, I don't mind "replace only this one out of the four-patch series" at all as long as what's being replaced is marked clearly enough (which you did in this case).

But I thought J6t had problems with what this particular patch does, not how the patch was indented? So I'd wait for more comments and hopefully an Ack from him before touching this one.

Previous: Ramsay Jones
Message 2 of 2 in “Add explicit Cygwin check to guard WIN32 header inclusion”
  1. 4/4 Add explicit Cygwin check to guard WIN32 header inclusionRamsay Jones, Nov 9, 2009
  2. Junio C HamanoNov 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.