Re: [PATCH] Makefile: determine the list of header files using a glob
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 30, 2009, 08:45 UTC
- Message-ID
- <7vd41w4zp4.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20091230080002.GA31088@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 13 quoted lines
> On Fri, Nov 27, 2009 at 10:28:38AM -0800, Junio C Hamano wrote: >> Mike Hommey <mh@glandium.org> writes: >> ... >> > Then it's fine. But shouldn't that be noted somewhere, like in the >> > INSTALL file ? >> >> Surely. Please make it so. > > I had another idea in the interim. If GNU make is necessary, why not > make the Makefile an explicit GNU make only Makefile, by renaming it > GNUmakefile ? > > That wouldn't remove the need to add a note in the INSTALL file, though.
I think you answered the question yourself.
Personally, when I am dealing with other people's projects, I dislike ones that do not name their own Makefile "Makefile", as I traditionally have done my local customization by having a higher precedence Makefile ("makefile" in the old world order, or "GNUmakefile" for gmake) that sets things up and then call into upstream "Makefile". For this project, since I am the upstream, I do want to keep the file named "Makefile".