Re: [WIP PATCH 1/4] Prepare checkout_entry() for recursive checkout of submodules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 9, 2010, 21:59 UTC
- Message-ID
- <7vd3y81e3s.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4BBF9DC9.8030905@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 11 quoted lines
> +int checkout_submodule(const char *path, const unsigned char sha1[20], int force)
> +{
> + struct strbuf buf = STRBUF_INIT;
> + struct child_process cp;
> + const char *hex_sha1 = sha1_to_hex(sha1);
> + const char *argv[] = {
> + "checkout",
> + force ? "-qf" : "-q",
> + hex_sha1,
> + NULL,
> + };Why force -q?
Show 6 quoted lines
> + strbuf_addf(&buf, "%s/.git/", path);
> + if (!is_directory(buf.buf)) {
> + strbuf_release(&buf);
> + /* The submodule is not populated, so we can't check it out */
> + return 0;
> + }This would give you an incorrect result if .git is a file that records "gitdir: overthere" (see read_gitfile_gently() in setup.c); I would expect it would become a fairly important ingredient if we ever enhance the submodule support to add submodule that disappears/reappears in the history.