git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] ll-merge: Normalize files before merging

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 11, 2010, 19:44 UTC
Message-ID
<7vd3vxicaw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4C11EB0D.20208@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 14 quoted lines
> Am 6/11/2010 9:34, schrieb Eyvind Bernhardsen:
>> On 11. juni 2010 07:49, Johannes Sixt wrote:
>>> I think you are going overboard here. Normalization should only happen
>>> only for data that moves from the worktree to the database. But during a
>>> merge, at most one part can come from the worktree, methinks; you are
>>> normalizing all three of them, though.
>> 
>> Well, that's sort of the point.  All three are normalized to (hopefully)
>> minimize the differences between them, increasing the chance of a
>> successful merge.
>
> I know what your point is. It is still inappropriate to call
> normalize_file() on data that comes from the repository. It is not the
> task of a merge procedure to blindly normalize data.

It is not "blindly", but "running normalization one _extra time_, as the repository data is supposed to be canonical already", which is utterly wrong.

Previous: Eyvind BernhardsenNext: Eyvind Bernhardsen
Message 7 of 8 in “[RFC] ll-merge: Normalize files before merging”
  1. Eyvind BernhardsenJun 10, 2010
  2. Johannes SixtJun 11, 2010
  3. Eyvind BernhardsenJun 11, 2010
  4. Johannes SixtJun 11, 2010
  5. Finn Arne GangstadJun 11, 2010
  6. Eyvind BernhardsenJun 11, 2010
  7. Junio C HamanoJun 11, 2010
  8. Eyvind BernhardsenJun 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.