Re: [PATCH 0/3] gitk: improve dark background

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2010, 01:34 UTC
Message-ID: <7vd3prpn10.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101126224136.GA26477@spacedout.fries.net>

David Fries <david@fries.net> writes:

Show 5 quoted lines

> I submitted the 'gitk: improve dark background' patch to the list,
> made improvements based on the feedback, and submitted the result two
> weeks ago without any further feedback.  I put my changes off of
> master, but gitk is identical in both maint and master.  Can you pull
> the changes?

I saw the patch, but I didn't really look at it (I don't use gitk very often, and I am an old-fashioned "darker ink on lighter sheet" user so I wouldn't be a good judge on your change).

I don't take patches to gitk or git-gui directly to my tree. Please Cc: the maintainer of that part of the system (Paulus, whom I am Cc'ing this message) the next time.

Thanks.

Show 14 quoted lines

> branch gitk_colors from
> git://gitorious.org/~dfries/git/dfriess-git-mainline.git
>
> This e-mail is also a replay to the last posting of the patches.
>
> On Wed, Nov 10, 2010 at 10:59:54PM -0600, David Fries wrote:
>> The gitk preferences allow for the user to select different colors.
>> The setui is even set to dynamically detect how light or dark the
>> background is and set the selection color to be the opposite, but
>> there are a few other color selections that don't currently work with
>> a dark background such as the black outlines.  This patch improves the
>> color selection.  In some cases it just needs to use the current
>> forground color, other places it is more complicated.
>> ...