git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: add known breakage of coloring when using extended patterns

From
Junio C Hamano <gitster@pobox.com>
Date
May 2, 2011, 17:37 UTC
Message-ID
<7vd3k1ngun.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DBEE672.5070707@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>> +	test_commit initial input "foo bar baz
...
>> +	git grep --color -e foo --or \( -e bar --and --not -e baz \) |
...
> The current code highlights the given search terms ("atoms").

Hmm, I was probably not paying attention to "coloring the parts that matched" topic at all, but wouldn't it be easier and more efficient to paint only "foo" without painting "bar baz"? We know the first term "foo" matches, and the rest \(...\) that is --or'ed does not have to even be evaluated, no?

Previous: René ScharfeNext: René Scharfe
Message 5 of 8 in “grep: add known breakage of coloring when using extended patterns”
  1. grep: add known breakage of coloring when using extended patternsBert Wesarg, May 2, 2011
  2. Johannes SixtMay 2, 2011
  3. Bert WesargMay 2, 2011
  4. René ScharfeMay 2, 2011
  5. Junio C HamanoMay 2, 2011
  6. René ScharfeMay 2, 2011
  7. Junio C HamanoMay 2, 2011
  8. René ScharfeMay 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.