git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/2] push: Don't push a repository with unpushed submodules

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2011, 22:22 UTC
Message-ID
<7vd3fxulw8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110822194728.GA11745@sandbox-rc>
Heiko Voigt <hvoigt@hvoigt.net> writes:
> Junio since you are one person listed in the api docs could you maybe
> quickly explain to me what this flag is used for?
It is used in order to avoid walking the object we have walked already.

Which in turn means that once you walk chain of objects, unless you remember the ones you walked and clear the marks after you are done, you cannot walk the object chain for unrelated purposes. See how functions like get_merge_bases_many() walk portions of graph for their own purpose and then avoid disrupting others by calling clear_commit_marks(). The use of TMP_MARK (and its clearing after the function is done with the marked objects) in remove_duplicate_parents() serve the same purpose.

Previous: Heiko VoigtNext: Heiko Voigt
Message 7 of 20 in “push: submodule support”
  1. 0/2 push: submodule supportFredrik Gustafsson, Aug 19, 2011
  2. 1/2 push: Don't push a repository with unpushed submodulesFredrik Gustafsson, Aug 19, 2011
  3. Junio C HamanoAug 19, 2011
  4. Junio C HamanoAug 20, 2011
  5. Junio C HamanoAug 21, 2011
  6. Heiko VoigtAug 22, 2011
  7. Junio C HamanoAug 22, 2011
  8. Heiko VoigtAug 23, 2011
  9. revision-walking: allow iterating revisions multiple timesHeiko Voigt, Aug 24, 2011
  10. Junio C HamanoAug 24, 2011
  11. 2/2 demonstrate format-callback used in combined diffJunio C Hamano, Aug 20, 2011
  12. Fredrik GustafssonAug 21, 2011
  13. 2/2 push: teach --recurse-submodules the on-demand optionFredrik Gustafsson, Aug 19, 2011
  14. Junio C HamanoSep 2, 2011
  15. Junio C HamanoOct 17, 2011
  16. Jens LehmannOct 18, 2011
  17. Phil HordDec 12, 2011
  18. Jens LehmannDec 12, 2011
  19. Phil HordDec 12, 2011
  20. Jens LehmannDec 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.