Re: [PATCH 1/2] pack-refs: remove all empty directories under $GIT_DIR/refs

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2012, 17:59 UTC
Message-ID: <7vd39lmetr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8Bh=FZ6kNN5hERK5_H7XnZ83BZ_EfsZ5XmJbrnn+CfgcQ@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

Show 9 quoted lines

> 2012/2/11 Junio C Hamano <gitster@pobox.com>:
>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> ...
>> Would it make more sense to note the
>> directory for which rmdir() fails in try_remove_empty_parents(), and
>> revisit only these directories, at least?
>
> That would leave empty directories not sharing the ref's path until
> the failed rmdir() unexamined, I think.

True. Thanks.

Show 6 quoted lines

>>> +     subpath = xmalloc(pathlen + 257);
>>
>> What is this 257 about?
>
> This function is a ripoff from get_ref_dir(). I think 257 is 255 below
> plus '/' and NIL.

I do not think there is any justification to copy-and-paste from code that predates the strbuf infrastructure these days.