Re: [PATCH] git-svn: forward -q to git-rebase
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 12, 2012, 16:54 UTC
- Message-ID
- <7vd354jwss.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1339515815-10752-1-git-send-email-kusmabite@gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
Show 16 quoted lines
> When calling "git svn rebase -q", we still get the message > "Current branch BRANCHNAME is up to date." from git-rebase, which > isn't quite as quiet as we could be. > > Fix this by forwarding the -q flag to git-rebase. > > Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com> > --- > > I just set up a cronjob that did a "git svn rebase -q", and noticed > it triggered cron to send me an e-mail every time. > > Since I'm not really interested in getting an e-mail every time the > script does nothing, but I'd like the option to get an e-mail whenever > it does something useful, perhaps something like this can benefit > other people as well?
If it matches what you would get from "git pull -q" run in a cronjob, I would say that is a sensible change to make.
Show 15 quoted lines
> git-svn.perl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 0b074c4..34baa43 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1590,6 +1590,7 @@ sub cmd_gc {
> sub rebase_cmd {
> my @cmd = qw/rebase/;
> push @cmd, '-v' if $_verbose;
> + push @cmd, '-q' if $_q;
> push @cmd, qw/--merge/ if $_merge;
> push @cmd, "--strategy=$_strategy" if $_strategy;
> push @cmd, "--preserve-merges" if $_preserve_merges;