Re: How do I run tests under Valgrind?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2012, 20:24 UTC
- Message-ID
- <7vd31d3iwl.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120922174741.GA6722@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Sat, Sep 22, 2012 at 03:03:58PM +0200, Stefano Lattarini wrote: > >> On 09/21/2012 10:49 PM, Jeff King wrote: >> > >> > Oh. It sounds like setting $SHELL to zsh is really the problem, then. If >> > it is not Bourne-compatible when called as "zsh", then it really should >> > be called in a way that turns on compatibility mode (bash will do this >> > when called as "sh", but you can also do it with "bash --posix"). >> > >> AFAIK, if Zsh is called as "sh", it too will run in Bourne compatibility >> mode; not sure how to force this compatibility from the command line though >> (albeit I'd guess there is some way to do so). >> [...] > > Thanks for digging. I think this case, though, is that we were simply > using the wrong variable ($SHELL instead of $SHELL_PATH). Your > workarounds would help if somebody put zsh into $SHELL_PATH, but > fundamentally that is not a sane thing to be doing, so I think we can > just consider doing so user error and not bother working around it.
Yeah, 100% agreed with your assessment, including the part thanking Stefano.
Thanks.