git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Commit message problem of reverting multiple commits

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2012, 16:34 UTC
Message-ID
<7vd2zhfoly.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAHtLG6Qn68TFVnd_8LSf6OMqHZduAFgk0Hd46E3vKgFHCjpksQ@mail.gmail.com>
乙酸鋰 <ch3cooli@gmail.com> writes:
Show 15 quoted lines
> I ran git 1.8.0 command line
>
> git revert --no-commit rev1 rev2
>
> I see a prepared commit message like
>
> Revert "<description from one commit>"
> This reverts commit <SHA1 of one commit>.
>
>
> The actual revert content is correct - it is all the relevant commits
> that were selected. I expect the message to reflect this:
>
> Revert "<description from commit1>", "<description from commit2>"
> This reverts commits <SHA1 of commit1>, <SHA1 of commit2>.
Hrmph.  I actually think the revert-content is not correct.

I think the command should not take more than one commit on the command line when --no-commit is in use in the first place (the same thing can be said for cherry-pick). After all, "git revert rev1 rev2" is to revert rev1 and then rev2 independently, so unless that option is spelled "--squash", the resulting history should have two commits that reverts rev1 and rev2 independently.

Previous: 乙酸鋰
Message 2 of 2 in “Commit message problem of reverting multiple commits”
  1. 乙酸鋰Nov 13, 2012
  2. Junio C HamanoNov 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.