git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/7] Allow git log to use mailmap file

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 15, 2012, 20:18 UTC
Message-ID
<7vd2ybrrvl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1355594754-27589-1-git-send-email-apelisse@gmail.com>
Antoine Pelisse <apelisse@gmail.com> writes:
Show 16 quoted lines
> Implement the feature suggested by Rich Mindwinter and Junio C Hamano
> (and following his advices)
>
>
>
> Allows git show/log commands to map author and committer
> names and emails using the mailmap file.
>
> Updates related to this second series:
>   - All tests are successful after each patch
>   - Use split_ident_line in shortlog.c
>   - Documentation has been added to git-log.txt
>   - Test has been added to check that we use the file
>   - Lots of improvements in the way strbufs are used
>   - New interface to map_user()
>   - Bunch of other fixes

The updated map_user() and its users look much nicer now. Applying your patches with "git am --whitespace=error" spots a few style violations, though.

> git glog --committer/--author is still not looking for mailmap user
> names.

I think we should stop using the header grep mechanism for these and instead keep two separate grep expressions in struct rev_info and use them in revision.c::commit_match(). The unification of header filter and message grep filter done in 2d10c55 (git log: Unify header_filter and message_filter into one., 2006-09-20) may not have been a good idea.

Thanks.
Previous: Antoine Pelisse
Message 9 of 9 in “Allow git log to use mailmap file”
  1. 0/7 Allow git log to use mailmap fileAntoine Pelisse, Dec 15, 2012
  2. 1/7 Use split_ident_line to parse author and committerAntoine Pelisse, Dec 15, 2012
  3. 2/7 mailmap: Remove buffer length limit in map_userAntoine Pelisse, Dec 15, 2012
  4. 3/7 mailmap: Simplify map_user() interfaceAntoine Pelisse, Dec 15, 2012
  5. 4/7 mailmap: Add mailmap structure to rev_info and ppAntoine Pelisse, Dec 15, 2012
  6. 5/7 pretty: Use mailmap to display username and emailAntoine Pelisse, Dec 15, 2012
  7. 6/7 log: Add --use-mailmap optionAntoine Pelisse, Dec 15, 2012
  8. 7/7 test: Add test for --use-mailmap optionAntoine Pelisse, Dec 15, 2012
  9. Junio C HamanoDec 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.