Re: Make GIT_USE_LOOKUP default?

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2013, 20:13 UTC
Message-ID: <7vd2uxrdh7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8AihriCDfN=cz7FjdHzZAhnPPGML_w8yWcVVrmTQLZyjw@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> This env comes from jc/sha1-lookup in 2008 (merge commit e9f9d4f), 5
> years ago. I wonder if it's good enough to turn on by default and keep
> improving from there, or is it still experimental?

The algorithm has been used in production in other codepaths like patch-ids and replace-object, so correctness-wise it should be fine to turn it on. I think nobody has bothered to benchmark with and without the environment to see if it is really worth the complexity.

It may be a good idea to try doing so, now you have noticed it ;-).