Re: [PATCH] patch-ids.c: cache patch IDs in a notes tree

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2013, 15:45 UTC
Message-ID: <7vd2suopda.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130513145948.GR2299@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

> This has the advantage that you get the benefit of the cache if you run
> "git log --cherry-mark" with the same paths more than once.  In my
> testing the cache is beneficial as soon as you examine more than one
> similar range (e.g. master...feature-A and then master...feature-B).

OK, so perhaps the notes that are keyed with commit ID will record multiple entries, one for each invocation pattern (i.e. all pathspec given, possibly with nonstandard options)?

"git diff -- t Documentation" and "git diff -- Docu\* t", even though they use different pathspec, would produce the same diff; instead of pathspec you may need to key with the actual list of paths in the patch, though.