Re: [PATCH revised] git_mkstemps: add test suite test

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2013, 20:50 UTC
Message-ID: <7vd2pqfssc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201308061902.r76J2W33027399@freeze.ariadne.com>

worley@alum.mit.edu (Dale R. Worley) writes:

Show 13 quoted lines

>>     git commit --allow-empty -m message <&-
>
> Though as of [fb56570] "Sync with maint to grab trivial doc fixes",
> that test doesn't fail for me if I revert to
>
> 		fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode);
> 		if (fd > 0)
> 			return fd;
>
> I haven't been watching the code changes carefully; has there been a
> fix that is expected to cause that?
>
> Dale

That is because a11c3964 (git: ensure 0/1/2 are open in main(), 2013-07-16) happened in the meantime, I think.