Re: [PATCH 1/9] Fix git patch header processing in git-apply.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 30, 2005, 01:34 UTC
- Message-ID
- <7vbr3g5hsb.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.58.0508291821010.3243@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 11 quoted lines
> On Mon, 29 Aug 2005, Junio C Hamano wrote: >> >> I, however, am not 100% convinced --ignore-applied is too >> dangerous to be useful in any conceivable use cases, at least >> not yet. For example, you might be cherry-picking a change from >> a foreign branch with 'git-diff-tree -p other~45 | git apply', >> where the current branch may have already aquired part of the >> changes that foreign branch contains since 45 generations ago. > > .. and that's why we use a three-way merge, and not diffs, to merge two > branches.
.. and that's why I recently rewrote revert, cherry-pick and rebase to use three-way merge as well ;-).
The code is simple enough and I see some beauty in it, but I honor your veto, at least for now.