Re: Tracking branch history
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 13, 2006, 16:43 UTC
- Message-ID
- <7vbqu1vps3.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0605130815550.3866@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> I actually disagree with Junio - I think the logging the name made sense. > If you have a shared repo with multiple people pushing to the same branch, > it's interesting to see who does the pushing.
Yes, I agree recording that information is interesting.
My comment was about how it is recorded. In the local case GIT_COMMITTER_IDENT is what you want as Shawn did in his original proposal, but remote "pushing into shared repository" case I do not think it is available in general.
Well, at least that was what I was thinking when I made that comment. However,
If the pushers arrange to have appropriate environment variables while receive-pack does its work (.git/config in the target repository is not an appropriate place to get user.* settings from in a shared setting), what you say makes perfect sense.
Having the usual enviornment available would be handy to make the hooks on the receiving end to do useful things anyway, so I retract that suggestion.
Show 6 quoted lines
> I also think it might be good to save the oldsha1 value. Yes, it _should_ > always be the previous sha1 logged, but it's interesting to see in case it > isn't (ie the ref was updated some other way), and it's also interesting > for the first entry after logging has been enabled. > > Linue
Yes, and also what user-level command was used to cause update the ref; was it a merge from remote, own commit, rewind/rebase?
Junia
;-)