git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fixed Cygwin CR-munging problem in mailsplit

From
Junio C Hamano <junkio@cox.net>
Date
May 27, 2006, 18:25 UTC
Message-ID
<7vbqtjfhp2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vfyivfhw4.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
Show 15 quoted lines
> I personally think this is a right change.  Provided if MTAs on
> the path between patch originator and you are not broken and
> your MUA saved the message with CR/LF distinction in the
> contents intact, this should do more right thing.
>
> I see broken patches every once in a while, but when they are
> mangled by the mailpath, CRLF is the least of the problem; they
> have other whitespace breakage that makes them unapplicable
> anyway.
>
> Having said that, however, that historically used to be a big IF
> with capital letters.
>
>
> I have a feeling that Linus did this on purpose.  For the

Heh, I had a trailing CR after the "with capital letters." and one blank line between paragraphs, but I now see two blank lines there. So even in this modern day, preserving CRLF is not something that happens by default -- you would need to make sure that everybody on your mailpath to the recipient is set up the right way.

> So I am slightly in favor of the change, but just barely.

So now I am less in favor of the change than when I wrote that response.

Previous: Junio C Hamano
Message 5 of 5 in “git-apply can't apply patches to CRLF-files”
  1. Salikh ZakirovMay 26, 2006
  2. Junio C HamanoMay 26, 2006
  3. Fixed Cygwin CR-munging problem in mailsplitSalikh Zakirov, May 27, 2006
  4. Junio C HamanoMay 27, 2006
  5. Junio C HamanoMay 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.