Re: [PATCH] git-fetch: Shell syntax fix for NetBSD
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 28, 2006, 21:04 UTC
- Message-ID
- <7vbqthdfpa.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060528204510.G51ab1cf8@leonov.stosberg.net>
Dennis Stosberg <dennis@stosberg.net> writes:
Show 9 quoted lines
> NetBSD's default shell does not accept an opening parenthesis in > a case switch. > > $ ./git-fetch > ./git-fetch: 219: Syntax error: word unexpected (expecting ")") > > --- > With this change applied to the next branch, all tests complete > successfully on NetBSD 3.0 without having bash installed.
Funny. Without the posixy open parenthesis, bash barfs ;-).
git-fetch: line 219: syntax error near unexpected token `;;'
git-fetch: line 219: ` *^*) continue ;;'So how about doing this instead? Does NetBSD default shell still work with it?
diff --git a/git-fetch.sh b/git-fetch.sh index 280f62e..69bd810 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -211,12 +211,12 @@ # Otherwise we do what we always did. reflist=$(get_remote_refs_for_fetch "$@") if test "$tags" then - taglist=$(IFS=" " && + taglist=`IFS=" " && git-ls-remote $upload_pack --tags "$remote" | while read sha1 name do case "$name" in - (*^*) continue ;; + *^*) continue ;; esac if git-check-ref-format "$name" then @@ -224,7 +224,7 @@ then else echo >&2 "warning: tag ${name} ignored" fi - done) + done` if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them.